fix(rpc): resolve EthTxIndex -1 sentinel before uint cast in receipt builder#1047
Open
Aboudjem wants to merge 3 commits intocosmos:mainfrom
Open
fix(rpc): resolve EthTxIndex -1 sentinel before uint cast in receipt builder#1047Aboudjem wants to merge 3 commits intocosmos:mainfrom
Aboudjem wants to merge 3 commits intocosmos:mainfrom
Conversation
Contributor
|
Please test this functionality. We require testing on all of our contributions. |
Author
|
Tests added in |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1047 +/- ##
==========================================
+ Coverage 64.64% 64.66% +0.01%
==========================================
Files 319 319
Lines 22170 22172 +2
==========================================
+ Hits 14332 14337 +5
+ Misses 6718 6715 -3
Partials 1120 1120
🚀 New features to boost your workflow:
|
Member
|
lints failing @Aboudjem |
Author
Verifies that EthTxIndex == -1 (unindexed sentinel) is resolved to the loop index instead of wrapping to max uint64. Ref cosmos#1032
Aboudjem
force-pushed
the
fix/ethtxindex-sentinel
branch
from
d4cc927 to
c195377
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1032
Summary
When
TxResult.EthTxIndexis-1(sentinel for "not yet assigned by indexer"),ReceiptsFromCometBlockcasts it directly touint, wrapping to18446744073709551615(MaxUint64). This breaks all modern Ethereum JS clients (viem, wagmi, ethers.js) withIntegerOutOfRangeError.Fix
Resolve the
-1sentinel using the loop index before the uint cast, matching the existing pattern inGetTransactionByHash(tx_info.go):```go
if txResult.EthTxIndex == -1 {
txResult.EthTxIndex = int32(i)
}
```
Testing
transactionIndexvaluesAuthor Checklist
mainbranch